Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create daily CI workflow #381

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Create daily CI workflow #381

wants to merge 4 commits into from

Conversation

viswavi
Copy link
Collaborator

@viswavi viswavi commented Nov 17, 2023

Description

This PR deletes the current "ci.yml" continuous integration workflow and instead creates two workflows, "pull_request_ci.yml" (which runs as a gate for all pull requests) and "daily_ci.yml" (which runs at 9am EST every morning). This will hopefully help us identify breaking library updates or broken code that sneaked into master sooner.

References

Followed https://docs.github.com/en/actions/using-workflows/reusing-workflows to guide this implementation.

Blocked by

N/A

@viswavi viswavi marked this pull request as draft November 17, 2023 04:18
@neubig
Copy link
Collaborator

neubig commented Mar 11, 2024

@viswavi is this dead? If so, we can close it.

@viswavi viswavi marked this pull request as ready for review March 11, 2024 20:20
@viswavi
Copy link
Collaborator Author

viswavi commented Mar 11, 2024

Oops, no I was waiting on #380 to get merged but forgot to get this final piece reviewed! This PR is ready to review and I'll push it once it is reviewed.

Thanks for the reminder @neubig

@neubig neubig self-requested a review March 12, 2024 21:26
Copy link
Collaborator

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, great, LGTM then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants