-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use timeout in connect function, #85
base: master
Are you sure you want to change the base?
Use timeout in connect function, #85
Conversation
…te monitor systems is unreachable that causing loss all other communications, maybe later should make it optional config parameter
Hmm, this exposes another problem: when using the timeout patch, it is not obvious that a timeout has occurred. At the very least, this feature should fix the "connect failed: Unknown error" message. I'm not especially happy with the connect timeout code anyway - it was added to support nut-scanner. But in the long run, if we are changing effective TCP timeout behavior, that timeout should be configurable. |
trying to resurrect the discussion:
@clepple @zykh @jimklimov thoughts and comments? |
Just to be sure, this is orthogonal to rapid data stale-unstale sequences reported a few weeks ago (as #651 OTOH)? |
Debian packaging: explicitly request libssl*-dev so OBS is not confus…
Looking at this PR open for so long (and with useful discussion above), I think this particular change will not be merged due to reasons articulated above, but a similar feature (with configuration, docs and all) can be considered in a future release. |
avoiding sigpipe in case one of remote monitor systems is unreachable that causing loss all other communications, maybe later should make it optional config parameter.
Example.
Monitoring 3 upses in upsmon.conf:
Before patch (waiting for default kernel timeouts and tcp_syn_retries, blocking all work for 190 seconds and finally got COMMBAD for all upses):
After patch (Pause 10 seconds on unreachable entry, other connections still alive):
So, if timeout is defined since 587d5f8, why not to use it?!
Patch tested and working.