Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix currently remaining markup which is not structured comments #35

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

jimklimov
Copy link
Member

Makes use of feature networkupstools/nut-website#43 to complete issue #29 after work on #33

Note that some un-structured markup remains, e.g. upsc output lines, comments in the ddl/Manufacturer_Name/Manufacturer_Name__Actual_Model__driver-name__2.7.1__01.nds template/example file, and a couple others. Normally there should not appear more of those.

TOTHINK: A coverage-style CI check with count of such lines?..

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…TRUCTURED COMMENT" lines)

Closes: networkupstools#29

Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
@jimklimov jimklimov requested a review from aquette August 3, 2023 13:35
@jimklimov jimklimov merged commit 3e7309e into networkupstools:master Aug 3, 2023
2 checks passed
@jimklimov jimklimov deleted the issue-ddl-32 branch August 3, 2023 13:35
@jimklimov jimklimov added the DDL Report for NUT Device Data/Dumps Library label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DDL Report for NUT Device Data/Dumps Library enhancement
Projects
Status: Done
Status: TODO
Development

Successfully merging this pull request may close these issues.

1 participant