This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👎 too smart |
and what about log that exception when just any referer exists? |
Why log entire exception? We can just add the referer information to access.log. |
but that 404 may be an error in application.. and who reads access log... |
I do. And to prevent errors in application I use INVALID_LINK_EXCEPTION. |
what if programmer self throws function actionDefault($number) {
if ($number > 3) {
throw new BadRequestException;
}
} but |
That's exactly why I use this approach. |
IMHO logging of 404 can be removed, it is usually done (in better way) by web server. |
@enumag: actually I don't see how that approach can solve the issued problem. |
dg
force-pushed
the
master
branch
3 times, most recently
from
June 29, 2015 13:32
7b54b1e
to
4b5a00e
Compare
Is there any way to merge this or should we close this? |
dg
force-pushed
the
master
branch
3 times, most recently
from
March 10, 2020 22:39
bccd0a3
to
cd8aa4a
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
January 5, 2021 05:33
5b5384d
to
6044000
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
October 7, 2021 01:49
2ed56c8
to
411dc39
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 404 occurred after pass through an anchor with referer on site self, it is probably bad link inside application self and not user's typo or search engine wrong index - it might be worth to send report.