Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netteForms.js: Set validation result CSS classes #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hranicka
Copy link
Contributor

Sometimes it's useful visually distinguish valid/invalid inputs.

We use something like the code in this PR.
When we need to use another CSS classes or something absolutely different, it's possible redefine Nette.markControlValid and Nette.markControlInvalid.

But I don't know if the PR should be accepted.
Also without it we can redefine Nette.validateControl, call original backed-up function and handle the result.

So most likely this will be closed without merge.
But I can try it and listen your opinions.

@fprochazka
Copy link
Contributor

I like it. Best part is you've essentialy created hooks that can be overriden with custom functions.

return true;
};


Nette.markControlValid = function(elem) {
Nette.switchClass(elem, 'control-invalid', 'control-valid');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have nette namespace.

@dg dg force-pushed the master branch 2 times, most recently from 131f7d2 to 532059a Compare May 21, 2015 11:49
@hranicka
Copy link
Contributor Author

This PR should be without any BC break.

Adds CSS classes according to validation result of each control.

Classes are prefixed with nette-* and should be compatible with applications using netteForms.js (thx @Majkl578 ).

Functions can be overridden with custom ones (Nette.markControlValid, Nette.markControlInvalid, Nette.switchClass).

So with this, on target system we can easily style valid/invalid form controls or add custom code executed for validation results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants