Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add databse string example #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PandelisZ
Copy link

The DB url requires some extra parameters to work

- Summary

[POP] 2020/01/08 12:25:03 warn - IMPORTANT! 'parseTime=true' option is required to work properly. Please add it to the database URL in the config!
[POP] 2020/01/08 12:25:03 warn - IMPORTANT! 'multiStatements=true' option is required to work properly. Please add it to the database URL in the config!

Might as well describe this in the readme as it is a requirement to use the service.

- Test plan

Documentation only

- Description for the changelog

Added an example database URI

- A picture of a cute animal (not mandatory but encouraged)

The DB url requires some extra parameters to work

The connection string requires the following two parameters: `?parseTime=true&multiStatements=true`

Eg: `mysql://user:pass@tcp(127.0.0.1:3306)/database?parseTime=true&multiStatements=true`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! adding this sounds good. how about adding this ?parseTime=true&multiStatements=true in the above example in line 60 (also you don't need mysql:// there)?
then we can keep the line 71, to explain it's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants