Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPE Apollo Chassis with Blade/Sled Servers and module #2139

Merged
merged 17 commits into from
Oct 27, 2024

Conversation

adamboutcher
Copy link
Contributor

This is to include the R2000 Series sled/blade chassis and the xl170 nodes. There is an RCM module specifically for this chassis too.

@danner26
Copy link
Member

Please resolve all test cases before marking this PR ready

@danner26 danner26 added the status: revisions needed This issue requires additional information to be actionable label May 18, 2024
@danner26 danner26 marked this pull request as draft May 18, 2024 18:00
@adamboutcher
Copy link
Contributor Author

What's failed?

@danner26
Copy link
Member

@adamboutcher the formatting check failed, you can run pre-commit run -a which will give you the full output of what is wrong.

@adamboutcher
Copy link
Contributor Author

It was initially missing some indentation so I added it but the second run I couldn't see the actual error output.

@danner26
Copy link
Member

danner26 commented Jun 7, 2024

If you run pre-commit run -a as defined in the readme you will see the formatting and errors. The first issue is that the file names are incorrect, the file name should match the model or part number. Please adjust the file names accordingly

Also, 2 of your files do not have file extensions.

@harryajc harryajc marked this pull request as ready for review October 27, 2024 08:17
@harryajc harryajc merged commit f51bafb into netbox-community:master Oct 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revisions needed This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants