Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor delay_epoch #277

Merged
merged 9 commits into from
Oct 24, 2024
Merged

chore: refactor delay_epoch #277

merged 9 commits into from
Oct 24, 2024

Conversation

quake
Copy link
Member

@quake quake commented Oct 23, 2024 •
edited
Loading

  1. add default delay epoch (24 hours), valid range is 1 hour ~ 14 days.
  2. deleted unused fields (payment_base_key, delayed_payment_base_key, revocation_pubkey)
  3. changed the channel id generation from revocation_basepoint to tcl_basepoint

contrun
contrun approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@contrun contrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Two small comments.

src/rpc/channel.rs Show resolved Hide resolved
@quake quake marked this pull request as ready for review October 23, 2024 11:08
@quake quake requested a review from chenyukang October 23, 2024 11:10
@quake quake merged commit 38b7547 into nervosnetwork:main Oct 24, 2024
16 checks passed
@contrun contrun mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contrun contrun contrun approved these changes

@chenyukang chenyukang Awaiting requested review from chenyukang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quake @contrun