Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Higher address bits are truncated in x64 assembly machine #425

Merged

Conversation

xxuejie
Copy link
Collaborator

@xxuejie xxuejie commented Mar 26, 2024

Note this is a bug that affects behavior, we can only fix it in VERSION2 and beyond

Note this is a bug that affects behavior, we can only fix it in VERSION2 and beyond
@xxuejie xxuejie force-pushed the fix-higher-address-bits-truncated-bug branch from 7e61d10 to 22fcf06 Compare March 26, 2024 02:15
@xxuejie xxuejie requested a review from mohanson March 26, 2024 02:23
Copy link
Collaborator

@mohanson mohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxuejie xxuejie merged commit f6df535 into nervosnetwork:develop Mar 26, 2024
11 checks passed
@xxuejie xxuejie deleted the fix-higher-address-bits-truncated-bug branch March 26, 2024 02:34
xxuejie added a commit to xxuejie/ckb-vm that referenced this pull request Mar 26, 2024
fix: Higher address bits are truncated in x64 assembly machine

Note this is a bug that affects behavior, we can only fix it in VERSION2 and beyond
mohanson pushed a commit that referenced this pull request Mar 26, 2024
fix: Higher address bits are truncated in x64 assembly machine

Note this is a bug that affects behavior, we can only fix it in VERSION2 and beyond
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants