Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve set_scripts partial bug #179

Merged

Conversation

quake
Copy link
Member

@quake quake commented Jan 16, 2024

this PR fixed a bug: stored min_filtered_block_number should be the min of all scripts' block_number when storage's filter_scripts is empty.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d31b8ef) 71.85% compared to head (a30cea5) 71.87%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
+ Coverage    71.85%   71.87%   +0.02%     
===========================================
  Files           25       25              
  Lines         6604     6606       +2     
===========================================
+ Hits          4745     4748       +3     
+ Misses        1859     1858       -1     
Flag Coverage Δ
unittests 71.87% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quake quake merged commit c5cd163 into nervosnetwork:develop Jan 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants