build(tests): type check integration.test.ts #413
Conversation
|
Looks like jest runs twice, once for *.test.ts, and once for *.test.js. |
| @@ -0,0 +1,4 @@ | |||
| module.exports = { | |||
| testEnvironment: 'node', | |||
| testPathIgnorePatterns: [".d.ts", ".js"] | |||
There was a problem hiding this comment.
maybe in a followup PR, should the jest config in package.json be migrated to (another) jest.config.js?
node-client/packages/neovim/package.json
Line 81 in 0640e9b
nit: seems like eslint doesn't check this file, but probably should:
| testPathIgnorePatterns: [".d.ts", ".js"] | |
| testPathIgnorePatterns: ['.d.ts', '.js'], |
There was a problem hiding this comment.
How about moving the jest.config.js content into packages/integration-tests/package.json for consistency?
There was a problem hiding this comment.
Sure that's fine. I have the impression that the .config.js files are the preferred approach these days (at least for eslint), but we will probably remove jest eventually (#333) so doesn't matter for now :)
There was a problem hiding this comment.
Great! After this is merged, I'll start working on it. Mocha seems like a good choice.
|
The unreliable test: emits "disconnect" after quit failed again, can u help me to rerun this job ? @justinmk |
Closes #352.