Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX 4608 - tethered site children uri path segment #4617

Merged
merged 6 commits into from
Oct 21, 2023
Merged

BUGFIX 4608 - tethered site children uri path segment #4617

merged 6 commits into from
Oct 21, 2023

Conversation

nezaniel
Copy link
Member

Resolves #4608

Documents with empty URI path are no longer ignored

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the 9.0 branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@github-actions github-actions bot added the 9.0 label Oct 13, 2023
@mhsdesign mhsdesign marked this pull request as draft October 18, 2023 07:22
@mhsdesign
Copy link
Member

Depends on #4616

@ahaeslich ahaeslich marked this pull request as ready for review October 18, 2023 17:19
@nezaniel nezaniel merged commit d86f619 into 9.0 Oct 21, 2023
7 checks passed
@nezaniel nezaniel deleted the 4608-tetheredSiteChildrenUriPathSegment branch October 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsdesign mhsdesign mhsdesign approved these changes

@dlubitz dlubitz dlubitz approved these changes

@skurfuerst skurfuerst Awaiting requested review from skurfuerst

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@kitsunet kitsunet Awaiting requested review from kitsunet

@ahaeslich ahaeslich Awaiting requested review from ahaeslich

Assignees
No one assigned
Labels
9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Tethered site children without uriPathSegment can never get one
3 participants
@nezaniel @mhsdesign @dlubitz