!!! FEATURE: Neos.Neos:Site NodeType

[mhsdesign]

resolves: #4531

Upgrade instructions

Your homepage must extend Neos.Neos:Site

For more upgrade information see neos/rector#66

Review instructions

Todo actually use the Neos.Neos:Site in the php code when querying.

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[kitsunet]

Makes sense I guess. I am sure though there will be many sites out there that do not have an explicit homepage nodetype right now and need structure adjustments for this. Do we / can we prepare one for this? Or a command ala turnsitenodeintonodetype <your.node:type> ? Could probably also happen during converting from old to new.

[mhsdesign]

Neos.ContentRepository.LegacyNodeMigration/Tests/Behavior/behat.yml.dist
AfterScenario # FeatureContext::failIfLastMigrationHasErrors()
RuntimeException: The last migration run led to an error: The site node "site-node-id" (type: "Some.Package:SomeNodeType") must be of type "Neos.Neos:Site". in Bootstrap/FeatureContext.php:90

[mhsdesign]

About an upgrade guide for people without dedicated page node i have created this task: neos/rector#66

[dlubitz]

I don't like the mix up of public constant and static method usage. Would be more clear if there were just one way of getting the nodeTypeName values. Even if it's more complex to get it in cases where you simply need the string value. But this is the price of type safetiness, isn't it?

[mhsdesign]

I don't like the mix up of public constant and static method usage.

i thought so too at first, but after seeing NodeTypeName::forSites()->value i was thankful for NodeTypeNameFactory::NAME_SITES ^^

But either way lets discuss this in a dedicated issue to not block this pr :D

[mhsdesign]

I resolved merge conflicts and tested this locally with the neos demo (adjustment neos/Neos.Demo#182) and the neos ui (adjustment neos/neos-ui#3629)

the neos ui e2e test succeed locally.

much has changed since the start ;)

[nezaniel]

Looks nice, I'll add the document uri path projection adjustments in a later pr

need re-review due to further adjustments ;)