Add CompilerPass to check if framework_bundle.property_access is enab…

…led (#1124)

fixtures/Bridge/Symfony/Application/config_property_access_disabled.yml

@@ -0,0 +1,23 @@
+#
+# This file is part of the Alice package.
+#
+# (c) Nelmio <hello@nelm.io>
+#
+# For the full copyright and license information, please view the LICENSE
+# file that was distributed with this source code.
+#
+
+framework:
+    annotations:
+        enabled: false
+    secret:                  NelmioAliceBundleSecret
+    serializer:
+        enabled: true
+    router:
+        resource:            ~
+        strict_requirements: '%kernel.debug%'
+        utf8: true
+    test:                    ~
+    session:
+        enabled: false
+    property_access: false

fixtures/Definition/Flag/MutableFlag.php

@@ -22,17 +22,14 @@ class MutableFlag implements FlagInterface
      */
     private $stringValue;
 
-    /**
-     * @var
-     */
     private $object;
 
     public function __construct(string $stringValue, $object)
     {
         $this->stringValue = $stringValue;
         $this->object = $object;
     }
-    
+
     public function __toString(): string
     {
         return $this->stringValue;

src/Bridge/Symfony/DependencyInjection/Compiler/CheckBundleDependenciesPass.php

@@ -0,0 +1,28 @@
+<?php
+
+/*
+ * This file is part of the Alice package.
+ *
+ * (c) Nelmio <hello@nelm.io>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Nelmio\Alice\Bridge\Symfony\DependencyInjection\Compiler;
+
+use LogicException;
+use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+
+class CheckBundleDependenciesPass implements CompilerPassInterface
+{
+    public function process(ContainerBuilder $container): void
+    {
+        if (!$container->has('property_accessor')) {
+            throw new LogicException('NelmioAliceBundle requires framework_bundle.property_access to be enabled.');
+        }
+    }
+}

src/Bridge/Symfony/NelmioAliceBundle.php

@@ -13,6 +13,7 @@
 
 namespace Nelmio\Alice\Bridge\Symfony;
 
+use Nelmio\Alice\Bridge\Symfony\DependencyInjection\Compiler\CheckBundleDependenciesPass;
 use Nelmio\Alice\Bridge\Symfony\DependencyInjection\Compiler\RegisterFakerProvidersPass;
 use Nelmio\Alice\Bridge\Symfony\DependencyInjection\Compiler\RegisterTagServicesPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
@@ -24,6 +25,7 @@ public function build(ContainerBuilder $container): void
     {
         parent::build($container);
 
+        $container->addCompilerPass(new CheckBundleDependenciesPass());
         $container->addCompilerPass(new RegisterFakerProvidersPass());
         $container->addCompilerPass(
             new RegisterTagServicesPass(

tests/Bridge/Symfony/DependencyInjection/CheckBundleDependenciesPassTest.php

@@ -0,0 +1,37 @@
+<?php
+
+/*
+ * This file is part of the Alice package.
+ *
+ * (c) Nelmio <hello@nelm.io>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Nelmio\Alice\Bridge\Symfony\DependencyInjection;
+
+use LogicException;
+use Nelmio\Alice\Symfony\KernelFactory;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @coversNothing
+ *
+ * @group integration
+ */
+class CheckBundleDependenciesPassTest extends TestCase
+{
+    public function testPropertyAccessDisabled(): void
+    {
+        static::expectException(LogicException::class);
+        static::expectExceptionMessage('NelmioAliceBundle requires framework_bundle.property_access to be enabled.');
+
+        $kernel = KernelFactory::createKernel(
+            __DIR__.'/../../../../fixtures/Bridge/Symfony/Application/config_property_access_disabled.yml',
+        );
+        $kernel->boot();
+    }
+}

tests/FixtureBuilder/Denormalizer/Fixture/SpecificationBagDenormalizer/Value/UniqueValueDenormalizerTest.php

@@ -116,7 +116,6 @@ public function testIfParsedValueIsDynamicArrayThenUniqueFlagAppliesToItsElement
         /** @var DynamicArrayValue $result */
         static::assertEquals(10, $result->getQuantifier());
         static::assertInstanceOf(UniqueValue::class, $result->getElement());
-        // @phpstan-ignore-next-line
         static::assertStringStartsWith('Dummy#', $result->getElement()->getId());
         static::assertEquals('parsed_value', $result->getElement()->getValue());
     }