Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables configuration cache #68

Merged
merged 2 commits into from
Dec 23, 2023
Merged

enables configuration cache #68

merged 2 commits into from
Dec 23, 2023

Conversation

nbaztec
Copy link
Owner

@nbaztec nbaztec commented Dec 23, 2023

Fixes #66

@coveralls
Copy link

coveralls commented Dec 23, 2023

Pull Request Test Coverage Report for Build #143

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build #141: 0.0%
Covered Lines: 330
Relevant Lines: 330

💛 - Coveralls

@nbaztec nbaztec merged commit 9130516 into main Dec 23, 2023
2 checks passed
@nbaztec nbaztec deleted the enable-configuration-cache branch December 23, 2023 15:47
@Spikhalskiy
Copy link

Spikhalskiy commented Dec 23, 2023

Do you think it actually does the trick? I suspect this PR enables gradle configuration cache during the build of the plugin itself. But I’m not sure it does anything to address the issue with applying the plugin with configuration cache enabled on user builds. I think to fix #66 some actual code change may be needed (some non-compliant with the cache usage of a project reference somewhere is likely)

@nbaztec
Copy link
Owner Author

nbaztec commented Dec 23, 2023

Hmm you might be right, do you have some kind of a sample repo I could reproduce in?

@Spikhalskiy
Copy link

Spikhalskiy commented Dec 23, 2023

I don’t at the moment, I work at a closed source project. But I may try to come up with a reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with gradle configuration cache
3 participants