Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1474, Increase UT_MAX_FUNC_STUBS value #1475

Closed

Conversation

tandharia
Copy link

Checklist (Please check before submitting)

Describe the contribution
Increases the value of UT_MAX_FUNC_STUBS from 200 to 300 to ensure that a unit test for SCH_ValidateMessageData() in the scheduler app passes successfully

Testing performed
Unit testing

Expected behavior changes
Allows the SCH_ValidateMessageData() unit test to run successfully

System(s) tested on
OS: Ubuntu 18.04

Contributor Info - All information REQUIRED for consideration of pull request
Tvisha Andharia - GSFC 582 intern

@skliper
Copy link
Contributor

skliper commented Aug 7, 2024

Why does the SCH test require such a large setting? Has it been confirmed there isn't an issue with the test before upping this value for every test by default?

@dzbaker dzbaker added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 8, 2024
@chillfig chillfig added continuous-integration unit-test Tickets related to the OSAL unit testing (functional and/or coverage) coverage and removed continuous-integration unit-test Tickets related to the OSAL unit testing (functional and/or coverage) labels Aug 8, 2024
@tandharia
Copy link
Author

The issue has been resolved - the scheduler unit tests have been updated and no longer need this change. I will be closing this pull request and the associated issue

@tandharia tandharia closed this Aug 9, 2024
@dzbaker dzbaker removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test for scheduler app requires increase in UT_MAX_FUNC_STUBS value
4 participants