Fix #1396, do not use intmax_t/uintmax_t types #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace these with long and unsigned long, respectively, as some old systems might not have these types even if it does provide stdint.h
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -417,7 +417,7 @@ | |||
| return TempBuf; | |||
| } | |||
|
|
|||
| static bool UtAssert_DoCompare(intmax_t ActualValueIn, UtAssert_Compare_t CompareType, UT_IntCheck_t ReferenceValueIn, | |||
| static bool UtAssert_DoCompare(long ActualValueIn, UtAssert_Compare_t CompareType, UT_IntCheck_t ReferenceValueIn, | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
| @@ -417,7 +417,7 @@ | |||
| return TempBuf; | |||
| } | |||
|
|
|||
| static bool UtAssert_DoCompare(intmax_t ActualValueIn, UtAssert_Compare_t CompareType, UT_IntCheck_t ReferenceValueIn, | |||
| static bool UtAssert_DoCompare(long ActualValueIn, UtAssert_Compare_t CompareType, UT_IntCheck_t ReferenceValueIn, | |||
Check notice
Code scanning / CodeQL
Function too long Note
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 27, 2023
*Combines:* cFE v7.0.0-rc4+dev356 osal v6.0.0-rc4+dev223 **Includes:** *cFE* - nasa/cFE#2416 *osal* - nasa/osal#1397 - nasa/osal#1399 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Jul 27, 2023
*Combines:* cFE v7.0.0-rc4+dev356 osal v6.0.0-rc4+dev223 **Includes:** *cFE* - nasa/cFE#2416 *osal* - nasa/osal#1397 - nasa/osal#1399 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Replace these with long and unsigned long, respectively, as some old systems might not have these types even if it does provide stdint.h
Fixes #1396
Testing performed
Build on vxworks 6.9 (gcc 4.3.3)
Expected behavior changes
Build should succeed
System(s) tested on
GSFC VxWorks build host
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.