Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Reduce variance in nodes-base benchmarks #9363

Merged

Conversation

ivov
Copy link
Contributor

@ivov ivov commented May 10, 2024

No description provided.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels May 10, 2024
Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #9363 will degrade performances by 88.48%

Comparing reduce-variance-in-nodes-base-benchmarks (abada87) with benchmark-nodes-base-v2 (f581e40)

Summary

⚡ 66 improvements
❌ 4 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark benchmark-nodes-base-v2 reduce-variance-in-nodes-base-benchmarks Change
nodes/Aws/S3/test/V1/AwsS3.file.upload.V1.workflow 46.2 ms 39.8 ms +16.17%
nodes/Aws/S3/test/V2/AwsS3.file.upload.V2.workflow 46.3 ms 63 ms -26.57%
nodes/Crypto/test/CryptoTest.workflow 42.4 ms 31.2 ms +35.79%
nodes/Discord/test/v2/node/channel/create.workflow 48.7 ms 43.7 ms +11.26%
nodes/Discord/test/v2/node/channel/deleteChannel.workflow 48.1 ms 43.4 ms +10.76%
nodes/Discord/test/v2/node/channel/get.workflow 63.1 ms 548.1 ms -88.48%
nodes/Discord/test/v2/node/channel/getAll.workflow 48.1 ms 43.2 ms +11.18%
nodes/Discord/test/v2/node/channel/update.workflow 49.6 ms 44.4 ms +11.63%
nodes/Discord/test/v2/node/member/getAll.workflow 49.2 ms 44.1 ms +11.54%
nodes/Discord/test/v2/node/member/roleAdd.workflow 48.4 ms 43.7 ms +10.92%
nodes/Discord/test/v2/node/member/roleRemove.workflow 48.5 ms 43.8 ms +10.82%
nodes/Discord/test/v2/node/message/deleteMessage.workflow 48.7 ms 43.6 ms +11.77%
nodes/Discord/test/v2/node/message/get.workflow 49.2 ms 44 ms +11.75%
nodes/Discord/test/v2/node/message/getAll.workflow 49.3 ms 43.9 ms +12.38%
nodes/Discord/test/v2/node/message/react.workflow 59.9 ms 43.8 ms +36.65%
nodes/Discord/test/v2/node/message/send.workflow 323.5 ms 46.1 ms ×7
nodes/Discord/test/v2/node/webhook/sendLegacy.workflow 21.4 ms 15.8 ms +35.99%
nodes/Files/ConvertToFile/test/toText.workflow 51.6 ms 42.4 ms +21.71%
nodes/Files/ReadWriteFile/test/ReadWriteFile.workflow 5 ms 4 ms +25.9%
nodes/Google/BigQuery/test/v2/node/executeQuery.workflow 7.1 ms 5.7 ms +25.96%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@ivov ivov merged commit 4ccef05 into benchmark-nodes-base-v2 May 10, 2024
7 of 8 checks passed
@ivov ivov deleted the reduce-variance-in-nodes-base-benchmarks branch May 10, 2024 17:12
adriencaccia pushed a commit to adriencaccia/n8n that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant