Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove all scope definition duplication (no-changelog) #11401

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

valya
Copy link
Contributor

@valya valya commented Oct 24, 2024

Summary

This is a follow up that removes the final bit of duplication from defining a scope.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Oct 24, 2024
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Oct 24, 2024

n8n    Run #7558

Run Properties:  status check failed Failed #7558  •  git commit 86650713b3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 valya 🗃️ e2e/*
Project n8n
Branch Review refactor-remove-all-scope-definition-duplication
Run status status check failed Failed #7558
Run duration 04m 51s
Commit git commit 86650713b3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 valya 🗃️ e2e/*
Committer Valya Bullions
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 404
View all changes introduced in this branch ↗︎

Tests for review

Failed  39-projects.cy.ts • 1 failed test

View Output Video

Test Artifacts
Projects > when starting from scratch > should move resources between projects Test Replay Screenshots Video
Failed  16-form-trigger-node.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  23-variables.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  32-node-io-filter.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  8-http-request-node.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 25 specs in Cypress Cloud.

Flakiness  14-mapping.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Data mapping > shows you can drop to inputs, including booleans Test Replay Screenshots Video
Flakiness  233-AI-switch-to-logs-on-error.cy.ts • 1 flaky test

View Output Video

Test Artifacts
AI-233 Make root node's logs pane active in case of an error in sub-nodes > should switch to logs tab on error, when NDV is already opened Test Replay Screenshots Video

@netroy
Copy link
Member

netroy commented Oct 24, 2024

e2e failure unrelated to this PR. I'll merge this.

@netroy netroy merged commit 95c5df0 into master Oct 24, 2024
30 of 33 checks passed
@netroy netroy deleted the refactor-remove-all-scope-definition-duplication branch October 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants