-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a way to preserve user-preferred mesh grid state #1460
base: develop
Are you sure you want to change the base?
Conversation
Turns out the same issue happens for the zoom and focus controls. Will also try to fix it for these in this PR. |
5fc8e09
to
3d6c5db
Compare
added some changes; |
Thanks @mockoocy, do you happen to have a screenshot of the changes ? |
|
@marcus-oscarsson I think we have different ideas how this mesh hidding/un-hidding is suppose to work. Like what is the actual desired behavior. Perhaps we can discuss this in a video meeting? I'm at least a bit confused right now. |
dc91738
to
0a68c99
Compare
@elmjag sure, we can have a quick chat if you like. How about tomorrow ? Otherwise I think the current proposal is fine maybe the color could be a bit more fun (other than dark gray :) ) and what do you think about a text perhaps under the hide button (saying "hidden by user" and perhaps "out of view" when hidden automatically) ? |
Fixes a bug / bad UX in which caused mesh grid to became unhidden after certain operations like DataCollection or Phase change.
The steps to reproduce the bugs were as following:
draw_grid
controlData Collection
buttonAfter the task was done, each of the grids was shown again.
It's also worth adding that in the demo beamline many of the motors seem to not be mocked, so the behavior can't be observed.
The reason for this behavior was further described in this Pull request mxcube/mxcubecore#1044 for mxcubecore. This PR will be marked as draft until the mxcubecore one is merged.
The fix writes to state set by user to
Shape.user_state
attribute on the mxcubecore side.When the data collection or phase change is finished, then the user-preferred state is restored by setting
Shape.state
to be equal toShape.user_state
.