Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hashbrown and switch to foldhash #8

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

thaliaarchi
Copy link
Contributor

hashbrown 0.15 was released this month, which changed its hasher from ahash to the faster foldhash. PR 445 updates egglog, but index_set keeps its own older version of hashbrown—hence this PR. This PR updates hashbrown and switches to foldhash.

The egglog benchmarks for the other PR only show regressions for what Saul says are unreliable tests with high variability. Testing updating symbol_table through those benchmarks doesn't seem to show any difference from a version which doesn't change symbol_table.

I wasn't able to figure out how to run the Criterion benchmarks in symbol_table—the typical invocations weren't doing the trick—, but that should give better insight.

@mwillsey
Copy link
Owner

Great! ty!

@mwillsey mwillsey merged commit 07e5d26 into mwillsey:main Oct 24, 2024
1 check passed
@thaliaarchi
Copy link
Contributor Author

Thanks!

Could you publish a release on crates.io, so it can be used in egglog?

@mwillsey
Copy link
Owner

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants