Update hashbrown and switch to foldhash #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashbrown
0.15 was released this month, which changed its hasher fromahash
to the fasterfoldhash
. PR 445 updates egglog, butindex_set
keeps its own older version of hashbrown—hence this PR. This PR updates hashbrown and switches to foldhash.The egglog benchmarks for the other PR only show regressions for what Saul says are unreliable tests with high variability. Testing updating symbol_table through those benchmarks doesn't seem to show any difference from a version which doesn't change symbol_table.
I wasn't able to figure out how to run the Criterion benchmarks in symbol_table—the typical invocations weren't doing the trick—, but that should give better insight.