Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure deployment works again #2

Merged
merged 3 commits into from
May 13, 2022
Merged

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Nov 22, 2021

This took some tries, but I got it working again.
This PR fixes https://github.com/mupixa/deploy-lambda/issues.

I got on the correct path based on comments in this issue: claudiajs/claudia#226

Apparently, some change with AWS lead to it failing when we try to update the function code & config at the same time.
Instead, we need to wait for the function code to be updated, before we try to update the config.

I re-wrote this to use an async function and updated the dependencies to the latest version, while at it.
It is working in our apps now again, with these changes. The API does not change.

@mydea mydea force-pushed the update-dependencies branch 3 times, most recently from 10ae3cb to d6d7665 Compare December 15, 2021 13:13
@valado valado merged commit 076c823 into mupixa:master May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants