Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SVG bitmap to BGRA unpremultiplied #3829

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Lpsd
Copy link
Member

@Lpsd Lpsd commented Oct 26, 2024

Resolves #3828

image

local w,h = 600, 450

local svg_bg = svgCreate(w, h, [[
	<svg width="604" height="454" viewBox="0 0 604 454" fill="none" xmlns="http://www.w3.org/2000/svg">
		<rect x="2" y="2" width="600" height="450" rx="10" fill="#21323A" fill-opacity="0.6"/>
		<rect x="1" y="1" width="602" height="452" rx="11" stroke="#30444D" stroke-opacity="0.6" stroke-width="2"/>
	</svg>
]])

dxSetTextureEdge(svg_bg, 'clamp')
local tex_bg = dxCreateTexture('bg.png', 'argb', false, 'clamp')

addEventHandler('onClientRender', root, function()
	dxDrawImage(150, 200, w, h, svg_bg, 0, 0, 0, 0xFFFFFFFF)
	dxDrawImage(150 + w + 100, 200, w, h, tex_bg, 0, 0, 0, 0xFFFFFFFF)
end)

bg.png
bg

Comment on lines +38 to +44
static enum eColorIndex : int
{
R = 0,
G = 1,
B = 2,
A = 3
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static has no effect here.
Enum may be private
Values can be be assigned by default here. You don't need all these = 0, = 1...
It declares R, G, B, A as valid values in CClientVectorGraphicDisplay methods. It's not critical, but bad

@TheNormalnij
Copy link
Member

The next lunasvg version has no convert method. Maybe we can optimize and prepare the solution for the future update:

Faster convert function

void CClientVectorGraphicDisplay::UnpremultiplyBitmap(Bitmap &bitmap)
{
    auto width = bitmap.width();
    auto height = bitmap.height();
    auto stride = bitmap.stride();
    auto rowData = bitmap.data();

    for (std::uint32_t y = 0; y < height; y++)
    {
        auto data = rowData;
        for (std::uint32_t x = 0; x < width; x++)
        {
            auto &b = data[0];
            auto &g = data[1];
            auto &r = data[2];
            auto &a = data[3];

            if (a != 0)
            {
                r = (r * 255) / a;
                g = (g * 255) / a;
                b = (b * 255) / a;
            }

            data += 4;
        }

        rowData += stride;
    }
}

Avoid additional memory allocation and memcpy

    IDirect3DSurface9* surface = m_pVectorGraphic->GetRenderItem()->m_pD3DRenderTargetSurface;
    if (!surface)
        return;

    // Lock surface
    D3DLOCKED_RECT LockedRect;
    if (SUCCEEDED(surface->LockRect(&LockedRect, nullptr, D3DLOCK_DISCARD)))
    {
        auto surfaceData = static_cast<std::uint8_t*>(LockedRect.pBits);
        auto stride = static_cast<std::uint32_t>(LockedRect.Pitch);

        Bitmap bitmap{surfaceData, pVectorGraphicItem->m_uiSizeX, pVectorGraphicItem->m_uiSizeY, stride};
        svgDocument->render(bitmap);
        UnpremultiplyBitmap(bitmap);

        // Unlock surface
        surface->UnlockRect();
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG colors are definitely wrong
4 participants