Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide login cmd from chat history #3725

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PlatinMTA
Copy link
Contributor

@PlatinMTA PlatinMTA commented Sep 15, 2024

With this the chat history won't store sensitive information regarding the /login command.

Fixes #2518

Censors /login command in chatbox history. This will also stop loging anything said using `/bind <key> chatbox login`
@PlatinMTA PlatinMTA changed the title Hide login and register cmd from chat history (solves #2518) Hide login and register cmd from chat history Sep 15, 2024
@FileEX
Copy link
Contributor

FileEX commented Sep 15, 2024

I think this is not a good step. A much better solution would be to add a checkbox in the settings "store login data in console history" or something similar.

When creating a server, scripts such as a login panel, depending on its level of advancement, you often need to reconnect to test it. Then entering, for example, "log" and pressing TAB is very useful to log in immediately without manually entering the login and password each time. I don't think we should completely abandon it, as it is still a useful functionality.

@PlatinMTA PlatinMTA changed the title Hide login and register cmd from chat history Hide login cmd from chat history Sep 15, 2024
@PlatinMTA
Copy link
Contributor Author

PlatinMTA commented Sep 15, 2024

I think this is not a good step. A much better solution would be to add a checkbox in the settings "store login data in console history" or something similar.

When creating a server, scripts such as a login panel, depending on its level of advancement, you often need to reconnect to test it. Then entering, for example, "log" and pressing TAB is very useful to log in immediately without manually entering the login and password each time. I don't think we should completely abandon it, as it is still a useful functionality.

Eh I guess we could add a CVAR (for default the command is censored, otherwise is not) but if you are developing a login panel I don't get why you would want to use the /login cmd? The console does censor the command but only after the session has ended, and the chat history is not saved after the session is done so I guess thats inconsistent. I still think we shouldnt save the values eitherway.

@FileEX
Copy link
Contributor

FileEX commented Sep 15, 2024

I think this is not a good step. A much better solution would be to add a checkbox in the settings "store login data in console history" or something similar.
When creating a server, scripts such as a login panel, depending on its level of advancement, you often need to reconnect to test it. Then entering, for example, "log" and pressing TAB is very useful to log in immediately without manually entering the login and password each time. I don't think we should completely abandon it, as it is still a useful functionality.

Eh I guess we could add a CVAR (for default the command is censored, otherwise is not) but if you are developing a login panel I don't get why you would want to use the /login cmd? The console does censor the command but only after the session has ended, and the chat history is not saved after the session is done so I guess thats inconsistent. I still think we shouldnt save the values eitherway.

When writing a script, e.g. for the login panel, when we often do a reconnect to test it, the login command is very useful, because to see the debugscript view or restart the script, e.g. after fixing errors, we still have to log in to the ACL. The login data is stored until the MTA is closed, then there is only the command itself in the history without data. I don't know if the same thing happens when connecting to another server, but it still doesn't change the fact that this functionality is simply useful and taking it away from people overnight can only be frustrating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/login command should not be stored in the chat history
2 participants