Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-static-bins.sh to include packages for Fedora #48

Closed
wants to merge 1 commit into from

Conversation

jbjorkang
Copy link
Member

@jbjorkang jbjorkang commented Oct 25, 2023

For future usage when build in Qubes VMs.


This change is Reviewable

@jbjorkang jbjorkang added the enhancement New feature or request label Oct 25, 2023
@jbjorkang jbjorkang requested a review from faern October 25, 2023 08:57
@jbjorkang jbjorkang self-assigned this Oct 25, 2023
Copy link
Member

@faern faern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been spending some time now on trying to formulate this in a way that I like. But I fail. I really don't think this file is the place to describe how to install Rust. It either becomes an essay, or it becomes something I don't like to recommend users doing.

Installing Rust is something you need to build any Rust project. This repo is not special. And not all repos can tell you how to get Rust, that would be massive repetition. But I understand how it can be confusing if this is the first Rust repo one arrives at, and it's not clear how to build it.

@@ -4,7 +4,7 @@
# and with logging enabled (controlled by RUST_LOG env var)
#
# You need the static version of glibc installed for this to work.
# On Fedora/RHEL that's: glibc-static.
# On Fedora/RHEL that's: sudo dnf install -y rust cargo glibc-static
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like the asymmetry between Ubuntu and Fedora now. One has the full command and one just has a package name. And one is rightfully just about glibc while the other lists all dependencies.

@jbjorkang
Copy link
Member Author

I have been spending some time now on trying to formulate this in a way that I like. But I fail. I really don't think this file is the place to describe how to install Rust. It either becomes an essay, or it becomes something I don't like to recommend users doing.

Installing Rust is something you need to build any Rust project. This repo is not special. And not all repos can tell you how to get Rust, that would be massive repetition. But I understand how it can be confusing if this is the first Rust repo one arrives at, and it's not clear how to build it.

Add something like a Makefile, write in the README:

To build this ensure you have the following packages installed: a, b, c

To build run make release

That is all I am after.

@jbjorkang jbjorkang closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants