-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for parsing maybenot machines #7107
base: main
Are you sure you want to change the base?
Conversation
cb12b39
to
1c224df
Compare
7fedf8a
to
c8e9a64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
wireguard-go-rs/src/lib.rs
line 215 at r2 (raw file):
Err(Error::Other) } }
This function should have a docstring and SAFETY-comments imo
abbf556
to
a7c59ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @hulthe)
wireguard-go-rs/src/lib.rs
line 215 at r2 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
This function should have a docstring and SAFETY-comments imo
Done.
This change is