Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for parsing maybenot machines #7107

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

dlon
Copy link
Member

@dlon dlon commented Oct 30, 2024


This change is Reviewable

hulthe
hulthe previously approved these changes Oct 30, 2024
@hulthe hulthe self-requested a review October 31, 2024 09:14
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)


wireguard-go-rs/src/lib.rs line 215 at r2 (raw file):

        Err(Error::Other)
    }
}

This function should have a docstring and SAFETY-comments imo

Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @hulthe)


wireguard-go-rs/src/lib.rs line 215 at r2 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

This function should have a docstring and SAFETY-comments imo

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants