Fix CVE-2024-49761 by upgrading rexml #7104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
force-pushed
the
fix-rexml-the-boogaloo-empire-strikes-back-ios-910
branch
from
7b836aa
to
1d980eb
Compare
buggmagnet
requested review from
raksooo,
pinkisemils and
albin-mullvad
as code owners
|
Would it not be better to ignore |
buggmagnet
commented
Oct 31, 2024
There was a problem hiding this comment.
We can also do that, yes. I'll make the change
Reviewable status: 0 of 4 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
fix-rexml-the-boogaloo-empire-strikes-back-ios-910
branch
from
1d980eb
to
bc77ad1
Compare
|
You still need an expiry date. I pointed this out on slack. No ignore is allowed to be indefinite. See instructions at top of root |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CVE-2024-49761 by upgrading rexml
This change is