Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on automatic use of Multihop when DAITA is enabled #7069

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Oct 24, 2024

This PR updates relay-selector.md to reflect that multihop may be used when DAITA is enabled to select a DAITA-compatible entry relay if needed.

TODO

Maybe we should mention that this behavior also overrides multihop since #6996?


This change is Reviewable

Copy link

linear bot commented Oct 24, 2024

docs/relay-selector.md Outdated Show resolved Hide resolved
@MarkusPettersson98 MarkusPettersson98 force-pushed the document-daita-overriding-multihop-in-relay-selector-des-1356 branch from 5fecf9b to 3d994b4 Compare October 28, 2024 08:59
Serock3
Serock3 previously approved these changes Oct 28, 2024
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jbjorkang and @MarkusPettersson98)


docs/relay-selector.md line 16 at r1 (raw file):

  for its obfuscating properties, not for any security properties it might have.
- DAITA - Short for "Defense against AI-guided Traffic Analysis". A technique supported on some
  WireGuard relays that makes website fingerprinting more difficult by sending random padding

I may be more future proof to not mention just adding padding packets, e.g. "...that makes fingerprinting more difficult by introducing network noise and making all packets the same size"

Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jbjorkang and @Serock3)


docs/relay-selector.md line 16 at r1 (raw file):

Previously, Serock3 (Sebastian Holmin) wrote…

I may be more future proof to not mention just adding padding packets, e.g. "...that makes fingerprinting more difficult by introducing network noise and making all packets the same size"

Now that you mention it, I don't think we need to define how DAITA works, only what the technique is intended to achieve. What do you think about the following statement:

- DAITA - Short for "Defense against AI-guided Traffic Analysis". A technique supported on some
  WireGuard relays that makes website fingerprinting more difficult.

?

@MarkusPettersson98 MarkusPettersson98 force-pushed the document-daita-overriding-multihop-in-relay-selector-des-1356 branch from 3d994b4 to b182750 Compare October 28, 2024 09:10
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jbjorkang and @Serock3)

@MarkusPettersson98 MarkusPettersson98 force-pushed the document-daita-overriding-multihop-in-relay-selector-des-1356 branch from b182750 to b611a5d Compare October 28, 2024 10:36
@MarkusPettersson98 MarkusPettersson98 merged commit 0844739 into main Oct 28, 2024
7 of 8 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the document-daita-overriding-multihop-in-relay-selector-des-1356 branch October 28, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants