Fix building for Xcode 15 and 16 #7063
Conversation
buggmagnet
force-pushed
the
test-out-xcode-161rc-ios-902
branch
from
f209f12
to
8d3ad1b
Compare
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status:
|
Can I have a patch here without the workaround for the optimizer? I'll try it out on Xcode 16.2 beta. |
There was a problem hiding this comment.
@pinkisemils All the changes in the PR are to work around the optimiser crashing when we build the MockRelease scheme
As long as you stick to Debug the code will build and run normally.
Reviewable status:
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/TunnelManager/UIApplication+Extensions.swift line 2 at r1 (raw file):
// // UIApplication+Extensions.swift
since the it's not extension anymore, I suppose we have to rename the file name and it's location.
|
Breaks all the same on the 16.2 beta 😿 Probably works with these changes too. |
buggmagnet
force-pushed
the
test-out-xcode-161rc-ios-902
branch
from
8d3ad1b
to
222b371
Compare
buggmagnet
force-pushed
the
test-out-xcode-161rc-ios-902
branch
from
222b371
to
dcde0c5
Compare
There was a problem hiding this comment.
Reviewable status: 16 of 19 files reviewed, 1 unresolved discussion (waiting on @mojganii and @rablador)
ios/MullvadVPN/TunnelManager/UIApplication+Extensions.swift line 2 at r1 (raw file):
Previously, mojganii wrote…
since the it's not extension anymore, I suppose we have to rename the file name and it's location.
Done.
This PR makes building both with Xcode 15 and Xcode 16 possible.
This change is