Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grammar in BuildInstructions.md #7060

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Typecosa
Copy link

@Typecosa Typecosa commented Oct 24, 2024

Changes to improve grammar and spelling in the file


This change is Reviewable

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Left a small nit ⛏️

Also, we can't accept PRs that merge main into them. Please rebase on top of main instead. Drop the last merge commit and run git rebase origin main where origin is the upstream repository git@github.com:mullvad/mullvadvpn-app.git. Thanks!

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Typecosa)


BuildInstructions.md line 144 at r1 (raw file):

./build.sh [--optimize]

This should produce an installer exe, pkg, or rpm+deb file in the dist/ directory.

We don't have any rules stating that we should use Oxford commas. Please, revert this change 😊

Code quote:

exe, pkg, or rpm+deb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants