Add support for Encrypted DNS Proxy #7043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rawa
changed the base branch from
main
to
add-encrypted-dns-as-an-access-method-in-the-daemon-des-1319
MarkusPettersson98
force-pushed
the
add-encrypted-dns-as-an-access-method-in-the-daemon-des-1319
branch
2 times, most recently
from
dc83da6
to
c2476d9
Compare
Rawa
force-pushed
the
implement-encrypted-dns-proxy-ui-droid-1374
branch
from
b7847fb
to
e586237
Compare
Rawa
changed the title
Rawa
force-pushed
the
implement-encrypted-dns-proxy-ui-droid-1374
branch
from
e586237
to
0fc5fcb
Compare
albin-mullvad
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
albin-mullvad
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
We should update the changelog and add tests as well, but I'm not sure if we want to do that in this PR or a separate one
Reviewable status:
Rawa
commented
Oct 22, 2024
There was a problem hiding this comment.
Let's do it in another one so we don't block desktop. We probably want to add some dialog with info as well. I've added issue to update changelog and add tests.
Reviewable status:
Rawa
force-pushed
the
implement-encrypted-dns-proxy-ui-droid-1374
branch
from
0fc5fcb
to
4e09fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is