Update settings migration workflow

[mojganii]

This PR optimizes the testing workflow by reusing the ios-end-to-end-tests for generating xcresult. it's a great step towards enhancing efficiency and consistency in iOS test reporting.

---

This change is 

[linear]

IOS-870 Convert JUnit Output Artifacts to xcresult for iOS Workflow

[buggmagnet]

Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 16 at r1 (raw file):

env:
  TEST_DEVICE_UDID: 00008130-0019181022F3803A
  OLD_APP_COMMIT_HASH: 895b7d98825e678f5d7023d5ea3c9b7beee89280

This commit doesn't seem to exist anymore
Do you have a link to a successful run of this flow that runs the tests correctly ?

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 62 at r1 (raw file):

      - uninstall_app
    uses: mullvad/mullvadvpn-app/.github/workflows/ios-end-to-end-tests.yml@main
    with:

I think we can remove the mullvad/mullvadvpn-app prefix here

[rablador]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)

[mojganii]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet)

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 16 at r1 (raw file):

Previously, buggmagnet wrote…

This commit doesn't seem to exist anymore
Do you have a link to a successful run of this flow that runs the tests correctly ?

I checked out this commit to address the issue reported at IOS-866. Additionally, you can view the successful execution of the flow here.

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 62 at r1 (raw file):

Previously, buggmagnet wrote…

I think we can remove the mullvad/mullvadvpn-app prefix here

we can't indeed. it is part of syntax.

[buggmagnet]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 62 at r1 (raw file):

Previously, mojganii wrote…

we can't indeed. it is part of syntax.

I'm not sure I follow, the previous version had this line
uses: ./.github/actions/ios-end-to-end-tests

Are you saying that wasn't working ?

[mojganii]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet)

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 62 at r1 (raw file):

Previously, buggmagnet wrote…

I'm not sure I follow, the previous version had this line
uses: ./.github/actions/ios-end-to-end-tests

Are you saying that wasn't working ?

they aren't equal. the previous one is ./.github/actions/ios-end-to-end-tests which is using the workflow in the checked out repo but mine is using workflow from main branch which mullvad/mullvadvpn-app/.github/workflows/ios-end-to-end-tests.yml@main

[mojganii]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @buggmagnet)

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 62 at r1 (raw file):

Previously, mojganii wrote…

they aren't equal. the previous one is ./.github/actions/ios-end-to-end-tests which is using the workflow in the checked out repo but mine is using workflow from main branch which mullvad/mullvadvpn-app/.github/workflows/ios-end-to-end-tests.yml@main

You can find more info here.

[buggmagnet]

Reviewable status: 7 of 8 files reviewed, 2 unresolved discussions (waiting on @mojganii and @rablador)

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 16 at r1 (raw file):

Previously, mojganii wrote…

I checked out this commit to address the issue reported at IOS-866. Additionally, you can view the successful execution of the flow here.

My bad, it looks like I didn't have the commit in my git history.

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 62 at r1 (raw file):
Ah right, reusable workflows
The docs does specify the following

• ./.github/workflows/{filename} for reusable workflows in the same repository.

Both are in our repo, but I think it's fine to leave it like this. After looking at it again, I think I prefer the explicit version. rather than the implicit one.

[rablador]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)

[buggmagnet]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mojganii)

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 13 at r2 (raw file):

    # At midnight every day.
    # Notifications for scheduled workflows are sent to the user who last modified the cron
    # syntax in the workflow file. If you update this you must have notifications for

As discussed offline, let's reinstate this comment

[rablador]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @mojganii)

[mojganii]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet)

---

.github/workflows/ios-end-to-end-tests-settings-migration.yml line 13 at r2 (raw file):

Previously, buggmagnet wrote…

As discussed offline, let's reinstate this comment

Done.

[rablador]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet)

[rablador]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @buggmagnet and @mojganii)