-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "smart routing" with "direct only" #6935
Replace "smart routing" with "direct only" #6935
Conversation
86dbf07
to
0eebd62
Compare
c3636e6
to
6eb7147
Compare
c79508b
to
02809a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 10 files at r1, 1 of 1 files at r3, 17 of 23 files at r5.
Reviewable status: 18 of 27 files reviewed, 1 unresolved discussion (waiting on @Serock3)
mullvad-types/src/wireguard.rs
line 101 at r5 (raw file):
Proposal:
#[cfr_attr(target_os = "android", serde(skip))]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 18 of 27 files reviewed, all discussions resolved (waiting on @hulthe)
mullvad-types/src/wireguard.rs
line 101 at r5 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
Proposal:
#[cfr_attr(target_os = "android", serde(skip))]
Done
02809a6
to
85fecf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 21 files at r2, 11 of 23 files at r5, 1 of 1 files at r7.
Reviewable status: 25 of 27 files reviewed, all discussions resolved (waiting on @hulthe)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 10 files at r1, 21 of 23 files at r5, 1 of 1 files at r7.
Reviewable status: 25 of 27 files reviewed, 1 unresolved discussion (waiting on @hulthe and @Serock3)
mullvad-daemon/src/management_interface.rs
line 359 at r7 (raw file):
log::debug!("set_daita_direct_only({value})"); let (tx, rx) = oneshot::channel(); self.send_command_to_daemon(DaemonCommand::SetDaitaUseMultihopIfNecessary(tx, !value))?;
Nit: value
is a bit vague. I would prefer if the variable name carried a hint on what the value represents, e.g. use_direct_only
.
Code quote:
let value = request.into_inner();
log::debug!("set_daita_direct_only({value})");
let (tx, rx) = oneshot::channel();
self.send_command_to_daemon(DaemonCommand::SetDaitaUseMultihopIfNecessary(tx, !value))?;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r9, all commit messages.
Reviewable status: 26 of 27 files reviewed, 1 unresolved discussion (waiting on @Serock3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r10, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Serock3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r11, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Serock3)
d7b2776
to
4928e45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r9, 1 of 2 files at r12, all commit messages.
Reviewable status: 26 of 27 files reviewed, all discussions resolved (waiting on @raksooo)
156909c
to
444258c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r13, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
444258c
to
120fa86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r14, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Simplify the logic for feature indicators
Also invert the behavior
We now simply show the "multihop" indicator there is an entry endpoint, regardless of whether it was activated manually or through DAITA. This reflects the intent to base the feature indicators on the current connection and not the user settings. There is no special indicator for "smart routing" or "direct only".
For android, it is set to true, as multihop is not supported. Note that in the daemon, the setting is called `use_multihop_if_necessary` and has the inverse meaning.
120fa86
to
7770131
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r13, 1 of 1 files at r14.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is