-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quantum resistance settings to preferences view if DEBUG is set #5806
Add quantum resistance settings to preferences view if DEBUG is set #5806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @acb-mv)
ios/MullvadVPN/View controllers/Preferences/PreferencesDataSource.swift
line 530 at r2 (raw file):
"QUANTUM_RESISTANCE_HEADER_LABEL", tableName: "Preferences", value: "Quantum Resistance",
Usually we try to have the same copy on all the platforms, following what Desktop wrote in most cases.
This should be titled "Quantum-resistant tunnel"
ios/MullvadVPN/View controllers/Preferences/PreferencesInteractor.swift
line 59 at r2 (raw file):
} func setQuantumResistance(_ newSetting: TunnelQuantumResistance) {
That function was defined but is never used
ios/MullvadVPN/View controllers/Preferences/PreferencesViewController.swift
line 160 at r2 (raw file):
tableName: "QuantumResistance", value: """ Text on quantum resistance goes here.
The text should say
This feature makes the WireGuard tunnel resistant to potential attacks from quantum computers.
It does this by performing an extra key exchange using a quantum safe algorithm and mixing the result into WireGuard’s regular encryption.
This extra step uses approximately 500 kiB of traffic every time a new tunnel is established.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 8 files reviewed, 3 unresolved discussions (waiting on @buggmagnet)
ios/MullvadVPN/View controllers/Preferences/PreferencesDataSource.swift
line 530 at r2 (raw file):
Previously, buggmagnet wrote…
Usually we try to have the same copy on all the platforms, following what Desktop wrote in most cases.
This should be titled "Quantum-resistant tunnel"
Done.
ios/MullvadVPN/View controllers/Preferences/PreferencesInteractor.swift
line 59 at r2 (raw file):
Previously, buggmagnet wrote…
That function was defined but is never used
Done.
ios/MullvadVPN/View controllers/Preferences/PreferencesViewController.swift
line 160 at r2 (raw file):
Previously, buggmagnet wrote…
The text should say
This feature makes the WireGuard tunnel resistant to potential attacks from quantum computers. It does this by performing an extra key exchange using a quantum safe algorithm and mixing the result into WireGuard’s regular encryption. This extra step uses approximately 500 kiB of traffic every time a new tunnel is established.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
…istance preferences UI options if DEBUG is not set
57ea04b
to
0014c3c
Compare
This adds a "Quantum resistance" menu to the VPN options with three modes: On, Off and Automatic. It is disabled if DEBUG is not set.
This change is