Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and remove libraries #5717

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Update and remove libraries #5717

merged 7 commits into from
Jan 25, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Jan 23, 2024 •
edited by faern
Loading

Removed libraries:

  • androids.constraintlayout
  • accompanist-systemuicontroller

Updated libraries:

  • androidx.core:core-ktx -> 1.12.0
  • androidx.lifecycle:lifecycle-runtime-ktx -> 2.7.0
  • androidx.lifecycle:lifecycle-viewmodel-ktx -> 2.7.0
  • ktfmt -> 0.16.0 (including format changes)
  • com.squareup.okhttp3:mockwebserver -> 4.12.0
  • commons-validator:commons-validator -> 1.8.0
  • io.insert-koin:koin-core -> 3.5.3
  • io.insert-koin:koin-android -> 3.5.3
  • io.insert-koin:koin-androidx-compose -> 3.5.3
  • io.insert-koin:koin-test -> 3.5.3

This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Jan 23, 2024
@Pururun
Copy link
Contributor Author

Pururun commented Jan 23, 2024

Seems to be that I updated the billing client by mistake and that triggered the owasp error, will fix.

@Pururun Pururun force-pushed the update-and-remove-libraries branch 3 times, most recently from 4274c89 to 9f14ac6 Compare January 24, 2024 08:13
Rawa
Rawa approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

albin-mullvad
albin-mullvad approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the update-and-remove-libraries branch 3 times, most recently from 7eb1950 to cfe2eec Compare January 25, 2024 10:49
@Pururun Pururun merged commit 68f3c6e into main Jan 25, 2024
15 of 16 checks passed
@Pururun Pururun deleted the update-and-remove-libraries branch January 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rawa Rawa Rawa approved these changes

@albin-mullvad albin-mullvad albin-mullvad approved these changes

Assignees
No one assigned
Labels
Android Issues related to Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pururun @Rawa @albin-mullvad