Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lazy list scroll crash #4974

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Aug 4, 2023


This change is Reviewable

Hold back emoji2 since newer versions require api level 34 which
is not yet stable.
@albin-mullvad albin-mullvad added bug Android Issues related to Android labels Aug 4, 2023
@albin-mullvad albin-mullvad self-assigned this Aug 4, 2023
@linear
Copy link

linear bot commented Aug 4, 2023

DROID-237 Lazy list scroll crash

Crash when quickly scrolling up in the split tunneling list using DPAD.

11526f79-6e00-4e4f-a76a-2fc9f8b34afe

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the fix-lazy-list-scroll-crash-droid-237 branch from da16ce2 to 0677c9d Compare August 4, 2023 14:57
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 2f6f85c into main Aug 4, 2023
17 checks passed
@albin-mullvad albin-mullvad deleted the fix-lazy-list-scroll-crash-droid-237 branch August 4, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants