-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularize tile service and its dependencies #4930
Merged
albin-mullvad
merged 17 commits into
main
from
move-tile-service-to-its-own-module-droid-225
Jul 27, 2023
Merged
Modularize tile service and its dependencies #4930
albin-mullvad
merged 17 commits into
main
from
move-tile-service-to-its-own-module-droid-225
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
force-pushed
the
move-tile-service-to-its-own-module-droid-225
branch
from
July 27, 2023 08:44
3b60193
to
21b570c
Compare
albin-mullvad
force-pushed
the
move-tile-service-to-its-own-module-droid-225
branch
from
July 27, 2023 09:54
21b570c
to
ea51297
Compare
sabercodic
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 213 of 213 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to modularize the tile service as well as the packages/classes it depends on. It also updates various scripts and documentation that are related.
This change is