Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the baselined lint issues #4916

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Jul 21, 2023


This change is Reviewable

@albin-mullvad albin-mullvad added the Android Issues related to Android label Jul 21, 2023
@albin-mullvad albin-mullvad self-assigned this Jul 21, 2023
@linear
Copy link

linear bot commented Jul 21, 2023

DROID-66 Fix baselined lint issues

Reivew and fix baselined lint issues reported by AGP android/app/lint-baseline.xml

The issues should either be fixed or in some few cases suppress via a lint.xml file (https://developer.android.com/studio/write/lint#sample-lint.xml-file).

@albin-mullvad albin-mullvad force-pushed the fix-baselined-lint-issues-droid-66 branch from d39b5a7 to a40408f Compare July 21, 2023 14:26
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 7087c16 into main Jul 21, 2023
13 checks passed
@albin-mullvad albin-mullvad deleted the fix-baselined-lint-issues-droid-66 branch July 21, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants