Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the number of REGISTER_IP_ADDRESSES calls #4219

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reduce the number of REGISTER_IP_ADDRESSES calls #4219

wants to merge 4 commits into from

Commits on Sep 29, 2023

  1. Never block route change callback when registering IPs with ST driver

    @dlon
    dlon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    2b8ccf5 View commit details
    Browse the repository at this point in the history

  2. Connections are redirected, not 'traffic'

    @dlon
    dlon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fb697fc View commit details
    Browse the repository at this point in the history

  3. Don't unregister tunnel IP in ST driver when reconnecting 

    Similarly, if we enter the error state due to being offline, don't
send an update

Since the IP is likely to be identical after reconnecting, this should
lower the number of IOCTLs to 0 from 2. There is a small risk that
some other network interface will take over the previous tunnel IP and
be incorrectly redirected to the default interface, though this should not
be dangerous from a security standpoint, since it only applies to
excluded processes
    @dlon
    dlon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1850dd1 View commit details
    Browse the repository at this point in the history

  4. Add burst guard to IP registration ioctl

    @dlon
    dlon committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    52b114a View commit details
    Browse the repository at this point in the history