get_apk: download() doesn't rename files anymore #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanLorenzo
force-pushed
the
fix-checksum-file
branch
from
8c1091f
to
6858559
Compare
escapewindow
approved these changes
Mar 10, 2017
| @@ -61,88 +58,41 @@ def signal_handler(self, signal, frame): | |||
|
|
|||
| def cleanup(self): | |||
There was a problem hiding this comment.
It may be useful to run this before we download, but the current behavior (not dying if it exists and overwriting) is probably acceptable.
There was a problem hiding this comment.
Good thinking. I created this good first bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs some integration tests0.2.0 incoming!