Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_apk: download() doesn't rename files anymore #19

Merged
merged 4 commits into from
Mar 13, 2017

Conversation

JohanLorenzo
Copy link
Contributor

@JohanLorenzo JohanLorenzo commented Mar 10, 2017

Needs some integration tests

0.2.0 incoming!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 92.17% when pulling 94a0eb2 on JohanLorenzo:fix-checksum-file into 6ec04a1 on mozilla-releng:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 92.507% when pulling d374cf0 on JohanLorenzo:fix-checksum-file into 6ec04a1 on mozilla-releng:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.7%) to 96.0% when pulling 6858559 on JohanLorenzo:fix-checksum-file into 6ec04a1 on mozilla-releng:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.7%) to 96.0% when pulling 6858559 on JohanLorenzo:fix-checksum-file into 6ec04a1 on mozilla-releng:master.

@@ -61,88 +58,41 @@ def signal_handler(self, signal, frame):

def cleanup(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be useful to run this before we download, but the current behavior (not dying if it exists and overwriting) is probably acceptable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking. I created this good first bug.

@JohanLorenzo JohanLorenzo merged commit 3a2fcf2 into mozilla-releng:master Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants