Refactor background tasks and services out of execution units #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
force-pushed
the
mikhail/actor-refactor
branch
4 times, most recently
from
97d3220
to
dc89834
Compare
Services and the background task are no longer callable through API on Executor, but can be spawned as tasks on the runtime. Remove async from some methods that don't need it. Conversely, make Executor::revert_block_head_to method async: The revert_commit data store operation can be expensive, put it on the background worker pool with spawn_blocking.
mzabaluev
force-pushed
the
mikhail/actor-refactor
branch
from
fbe7a0b
to
fa73301
Compare
mzabaluev
requested review from
0xmovses,
l-monninger and
andyjsbell
as code owners
l-monninger
requested changes
Aug 21, 2024
protocol-units/execution/opt-executor/src/executor/initialization.rs
Outdated
Show resolved
Hide resolved
|
|
||
| #[cfg(test)] | ||
| pub mod tests; | ||
|
|
||
| pub trait SuzukaFullNode { |
l-monninger
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
protocol-units,networks.Start on #63 by refactoring maptos-opt-executor, maptos-fin-view, and their integration in maptos-dof-execution and suzuka-full-node.
Testing
Locally:
cargo test -p maptos-opt-executorcargo test -p maptos-fin-viewExisting integration tests should pass in CI after the changes.