Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOSIP-31617: Sonar Fixes #1537

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

HimajaDhanyamraju2
Copy link
Contributor

@HimajaDhanyamraju2 HimajaDhanyamraju2 commented Jul 10, 2024

Fixed vulnerabilities, reliability issues and removed some duplications

HimajaDhanyamraju2 added 4 commits July 9, 2024 12:24
Signed-off-by: HimajaDhanyamraju2 <dhanyamraju.himaja2@mindtree.com>
Signed-off-by: HimajaDhanyamraju2 <dhanyamraju.himaja2@mindtree.com>
Signed-off-by: HimajaDhanyamraju2 <dhanyamraju.himaja2@mindtree.com>
HimajaDhanyamraju2 added 2 commits July 11, 2024 10:17
Signed-off-by: HimajaDhanyamraju2 <dhanyamraju.himaja2@mindtree.com>
Signed-off-by: HimajaDhanyamraju2 <dhanyamraju.himaja2@mindtree.com>
@@ -84,7 +84,7 @@ public ResponseDto sendEmail(String[] mailTo, String[] mailCc, String mailSubjec
}

@Async
private void send(String[] mailTo, String[] mailCc, String mailSubject, String mailContent,
public void send(String[] mailTo, String[] mailCc, String mailSubject, String mailContent,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we change this to public ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was mentioned that @async annotated methods must be public. Please check this sonar rule - https://sonarcloud.io/organizations/mosip/rules?open=java%3AS2230&rule_key=java%3AS2230

* @since 1.0.0
*
*/
public class HibernatePersistenceConstant {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot delete files since we are in LTS, confirmed on this to this to Sasi also

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can mark it deprecated, but we cannot delete the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants