Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PEFT Version #3494

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Bump PEFT Version #3494

wants to merge 1 commit into from

Conversation

snarayan21
Copy link
Contributor

What does this PR do?

Bumps peft to min 0.12.0, since it contains a crucial memory-saving fix when saving adapters.

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 requested a review from a team as a code owner July 26, 2024 00:27
@snarayan21 snarayan21 marked this pull request as draft July 31, 2024 15:16
@snarayan21
Copy link
Contributor Author

Converting to draft since we will need to bump peft version anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snarayan21 @mvpatel2000