Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Certora] Quick refactor #696

Merged
merged 3 commits into from
Oct 10, 2024
Merged

[Certora] Quick refactor #696

merged 3 commits into from
Oct 10, 2024

Conversation

QGarchery
Copy link
Contributor

@QGarchery QGarchery commented Oct 9, 2024 •
edited
Loading

This PR:

  • removes the unnecessary priceChanged = false in the spec. This is not necessary because we assume that priceChanged is false at the end, and the only way it can change is by being set to true
  • removes the setting cache to none in ExactMath.conf, which was there as an artifact of an old timeout
  • formats the conf files according to Prettier rules for JSON files
  • solves a timeout in StayHealthyLiquidate that was coming back at every new CVL release

@QGarchery QGarchery added the verif Modifies the formal verification label Oct 9, 2024
@QGarchery QGarchery self-assigned this Oct 9, 2024
@colin-morpho colin-morpho merged commit d60e123 into main Oct 10, 2024
17 checks passed
@colin-morpho colin-morpho deleted the certora/quick-refactor branch October 10, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@colin-morpho colin-morpho colin-morpho approved these changes

@adhusson adhusson Awaiting requested review from adhusson

Assignees

@QGarchery QGarchery

Labels
verif Modifies the formal verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QGarchery @MathisGD @colin-morpho