Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update audit #694

Merged
merged 2 commits into from
Sep 29, 2024
Merged

update audit #694

merged 2 commits into from
Sep 29, 2024

Conversation

MathisGD
Copy link
Contributor

  • our answer for the high vulnerability has been added (the previous report doesn't contain any of the answers / fixes)

@MathisGD MathisGD self-assigned this Sep 27, 2024
@MathisGD MathisGD changed the title chore: update audit update audit Sep 27, 2024
QGarchery
QGarchery approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@QGarchery QGarchery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every medium has Morpho Labs response, except:

  • 3.2.5 & 3.2.6, both fixed with a new computation of repaidShares in liquidate
  • 3.2.8, where I think that it had one fix with setting a smaller max rate (also monitoring markets at creation)

@MathisGD MathisGD merged commit 3886a78 into main Sep 29, 2024
16 checks passed
@MathisGD MathisGD deleted the chore/audits branch September 29, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@MerlinEgalite MerlinEgalite Awaiting requested review from MerlinEgalite

Assignees

@MathisGD MathisGD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MathisGD @QGarchery