-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Certora] Assets accounting when entering a position #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
force-pushed
the
certora/assets-accounting
branch
from
December 4, 2023 17:07
df92290
to
343b36d
Compare
QGarchery
requested review from
MathisGD,
a team,
Rubilmax,
MerlinEgalite and
Jean-Grimal
and removed request for
a team
December 4, 2023 17:21
MathisGD
reviewed
Dec 5, 2023
MathisGD
previously approved these changes
Dec 5, 2023
let's go to main to not pollute |
MathisGD
approved these changes
Dec 5, 2023
MerlinEgalite
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles one of the "additional properties" point in #390 where it is shown that users do not get more assets than what they are owed when entering a position.