Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action): fix outdated dev-dependencies section handling #27

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

catcombo
Copy link
Contributor

I use action-setup-python-poetry in my personal project and I got the following error:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/runner/work/_actions/moneymeets/action-setup-python-poetry/master/action_setup_python_poetry/invalid_package_versions.py", line 34, in main
    if invalid_versions := get_invalid_package_versions(pyproject_path.read_text()):
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/_actions/moneymeets/action-setup-python-poetry/master/action_setup_python_poetry/invalid_package_versions.py", line 23, in get_invalid_package_versions
    *poetry_data["dev-dependencies"].items(),
     ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
KeyError: 'dev-dependencies'

The reason is that dev-dependencies is no longer used since poetry 1.2. If you create a new pyproject.toml now, it won't contain dev-dependencies section anymore.

Copy link
Contributor

@marns93 marns93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pchorus pchorus merged commit 63387ea into master Apr 24, 2024
4 checks passed
@pchorus pchorus deleted the feature/fix-dependencies-detection branch April 24, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants