Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(action): add ecs deployment workflow #1

Merged
merged 1 commit into from
Feb 15, 2024
Merged

feat(action): add ecs deployment workflow #1

merged 1 commit into from
Feb 15, 2024

Conversation

IamAbbey
Copy link
Contributor

No description provided.

felix11h
felix11h reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@felix11h felix11h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, @IamAbbey. I have added some higher level comments for now, maybe you can have a look. Thank you!

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
actions_helper/main.py Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
felix11h
felix11h requested changes Feb 14, 2024
View reviewed changes
custom-deploy-steps/get-image-uri/action.yml Outdated Show resolved Hide resolved
actions_helper/main.py Show resolved Hide resolved
actions_helper/main.py Outdated Show resolved Hide resolved
custom-deploy-steps/create-task-definition/action.yml Outdated Show resolved Hide resolved
custom-deploy-steps/create-task-definition/action.yml Outdated Show resolved Hide resolved
custom-deploy-steps/create-task-definition/action.yml Outdated Show resolved Hide resolved
custom-deploy-steps/create-task-definition/action.yml Outdated Show resolved Hide resolved
felix11h
felix11h reviewed Feb 14, 2024
View reviewed changes
action.yml Outdated Show resolved Hide resolved
felix11h
felix11h approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@felix11h felix11h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@IamAbbey IamAbbey force-pushed the feature/MD-7037-implement-ecs-deployment-workflow branch from 921f49a to ebff0a3 Compare February 15, 2024 12:55
@IamAbbey
Copy link
Contributor Author

/rebase

@mergealot mergealot force-pushed the feature/MD-7037-implement-ecs-deployment-workflow branch from ebff0a3 to 0b65ba6 Compare February 15, 2024 12:55
@IamAbbey IamAbbey merged commit 5aa238b into master Feb 15, 2024
4 checks passed
@IamAbbey IamAbbey deleted the feature/MD-7037-implement-ecs-deployment-workflow branch February 15, 2024 12:58
@felix11h felix11h mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix11h felix11h felix11h approved these changes

@marns93 marns93 Awaiting requested review from marns93 marns93 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IamAbbey @felix11h