Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update imports #8262

Closed
wants to merge 2 commits into from
Closed

update imports #8262

wants to merge 2 commits into from

Conversation

twhetzel
Copy link
Collaborator

I refreshed the imports following this page and updating the 'imports/manual_seed.txt' file using the new content from https://docs.google.com/spreadsheets/d/1UME3pTeR42hwNt1I6RPl0nvJKVfTIeJqhx80laAlD50/edit?gid=0#gid=0.

I had to use 60GB of memory in order to get this to complete without getting an Out of Memory Error cc: @matentzn

twhetzel
twhetzel commented Oct 22, 2024
View reviewed changes
src/ontology/mondo-edit.obo
@@ -570873,7 +570873,7 @@ synonym: "coat color albinism, oculocutaneous type IV, Japanese medaka" RELATED
xref: OMIA:001821-8090 {source="MONDO:equivalentTo"}
is_a: MONDO:1011321 {source="OMIA:001821-8090", source="https://orcid.org/0000-0002-5002-8648"} ! hereditary disease, non-human animal
is_a: MONDO:1012579 {source="OMIA:001821-8090", source="https://orcid.org/0000-0002-5002-8648"} ! oculocutaneous albinism, non-human animal
relationship: has_material_basis_in_germline_mutation_in http://identifiers.org/ncbigene/100049347 {source="OMIA:001821-8090", source="https://orcid.org/0000-0002-5002-8648"}
relationship: has_material_basis_in_germline_mutation_in http://identifiers.org/ncbigene/100049347 {source="OMIA:001821-8090", source="https://orcid.org/0000-0002-5002-8648"} ! slc45a2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this ncbigene UID does have a lowercase label: https://www.ncbi.nlm.nih.gov/gene/?term=100049347

@twhetzel
Copy link
Collaborator Author

NOTE: The qc check failed on the first push:

FAIL Rule ../sparql/qc/general/qc-single-child.sparql: 1 violation(s)
entity,property,value
http://purl.obolibrary.org/obo/MONDO_0004548,http://www.w3.org/2000/01/rdf-schema#subClassOf,http://purl.obolibrary.org/obo/MONDO_0020541

I did pull from master before creating the feature branch and refreshing the imports so I am not sure why this error is only happening now. I did add an 'exclude from qc' check for single_child and pushed that change.

@twhetzel
Copy link
Collaborator Author

NOTE: Also testing out a new PR for refreshing the imports #8264

@twhetzel
Copy link
Collaborator Author

The new PR is returning the same error so I will close this older PR.

@twhetzel twhetzel closed this Oct 22, 2024
@matentzn matentzn mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabrinatoro sabrinatoro Awaiting requested review from sabrinatoro sabrinatoro is a code owner

Assignees

@sabrinatoro sabrinatoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twhetzel @sabrinatoro