Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical definition of "ovarian granulosa cell tumor" is redundant #8268

Open
matentzn opened this issue Oct 23, 2024 · 8 comments
Open

Logical definition of "ovarian granulosa cell tumor" is redundant #8268

matentzn opened this issue Oct 23, 2024 · 8 comments
Assignees

Comments

@matentzn
Copy link
Member

matentzn commented Oct 23, 2024

#8262(closed) #8264 caused the following failure as pointed out by @twhetzel:

DISJOINT-SIB-OF ovarian granulosa cell tumor SubClassOf Nothing

Axiom Impact

Axioms used 1 times

The problem is a bit opaque as it is caught by an ancient check which has long since been superceded by robot reason --allow-equivalent-classes none (the test injects hypothetical siblings and makes sure they can theoretically exist, thereby ensuring a child is not the same as its parent).

Here is the issue:

granulosa cell tumor is defined as a granulosa cell tumor EquivalentTo neoplasm and (disease has location some granulosa cell) and ovarian granulosa cell tumor is defined as a granulosa cell tumor and (disease has location some ovary). Unfortunately, through a chain of inference in CL, granulosa cell is considered a part of the ovaries. So saying that ovarian granulosa cell tumor is has (disease has location some ovary) is redundant, therefore the two classes are considered the same.

This is a great catch by QC. My assumption is that either the fact that granulosa cell is considered a part of the ovaries is wrong, or ovarian granulosa cell tumor is logically underspecified!

@twhetzel
Copy link
Collaborator

Thanks @matentzn - that was my general impression from the qc error log. Did you come across why this happened now as a result of running the refresh imports?

@sabrinatoro or @nicolevasilevsky are either of you able to take the curator role on this to resolve this issue?

@matentzn
Copy link
Member Author

Did you come across why this happened now as a result of running the refresh imports?

It is either due to changes in CL classification (one that made granulosa cell part of the ovaries) or because the role chain disease has location < disease has location o part of was added to RO!

@nicolevasilevsky
Copy link
Member

@sabrinatoro or @nicolevasilevsky are either of you able to take the curator role on this to resolve this issue?

no, I can't, sorry

@nicolevasilevsky nicolevasilevsky removed their assignment Oct 23, 2024
@matentzn
Copy link
Member Author

A quick fix is to remove the logical definition of ovarian granulosa cell tumor, but someone should probably google the following:

Are all granulosa cell tumors are by definition "ovarian"?

@twhetzel
Copy link
Collaborator

From a few references I've seen:

@cmungall
Copy link
Member

cmungall commented Oct 23, 2024

here's the issue

id: MONDO:0006036
name: granulosa cell tumor
def: "A slow-growing, malignant tumor, characterize by the presence of granulosa-like cells and Call-Exner bodies, that is almost always found in the ovary. In rare cases, it has also been found in the testicle. There are two types of granulosa cell tumor that can be distinguished under the microscope: the adult and the juvenile. The testicular juvenile granulosa cell tumors are perhaps the most common congenital testicular neoplasms." [NCIT:C3070]
intersection_of: MONDO:0005070 ! neoplasm
intersection_of: disease_has_location CL:0000501 ! granulosa cell

we need better DPs for neoplasm->CL

@sabrinatoro
Copy link
Collaborator

I agree with everything said here. In addition:

  • "granulosa cell tumor" can occur in ovary and in testis. Therefore, "granulosa cell tumor" is NOT equivalent to "ovarian granulosa cell tumor" (this had to be confirmed).

  • After reading the definition for "granulosa cell tumor", I think that the logical definition of "neoplasm located in a granulosa cell" is not correct. "granulosa cell tumor" is "characterized by the presence of granulosa-like cells and Call-Exner bodies". (ie it is NOT "located in"). I therefore removed the logical definition for this term. The resulting classification seems more sane.

  • I agree with Chris that the DPs for neoplasm located in cells should be reviewed. A new issue should be created for this (@twhetzel can you please create this issue? thank you)

PR has been updated; waiting for QC checks to run.

@twhetzel
Copy link
Collaborator

Sure, I added an issue referencing back to this for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants